Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multi combobox. selectedItems can't be updated after the first rendering #12465

Closed
wants to merge 5 commits into from
Closed

fix: multi combobox. selectedItems can't be updated after the first rendering #12465

wants to merge 5 commits into from

Conversation

khotcholava
Copy link
Contributor

@khotcholava khotcholava commented Sep 23, 2024 •
edited
Loading

fix: multi combobox. selectedItems can't be updated after the first rendering

closes #11981

Description

  • Fixed multi combobox value set
Screen.Recording.2024-09-23.at.16.29.41.mov

@khotcholava
bugfix: multi combobox. selectedItems can't be updated after the firs…
78af5fa 
…t rendering

closes (#11981)[#11981]

## Description
- Investigating issue regarding update of multi combobox value
@khotcholava
fix: multi combobox. selectedItems can't be updated after the first r…
51c1c8a 
…endering

closes (#11981)[#11981]

## Description
- Fixed multi combobox value set
@khotcholava khotcholava self-assigned this Sep 23, 2024
@khotcholava
fix: multi combobox. selectedItems can't be updated after the first r…
dc44702 
…endering

closes (#11981)[#11981]

## Description
- Clean up the code
- Rolled back changes
@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024

✅ Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 51c1c8a
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/66f160232c859400081f9df5
😎 Deploy Preview https://deploy-preview-12465--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 61294aa
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/66ffa0a44971db00081c3b28
😎 Deploy Preview https://deploy-preview-12465--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 61294aa):

https://fundamental-ngx-gh--pr12465-fix-11981-multi-comb-tctqkr3y.web.app

(expires Mon, 07 Oct 2024 08:05:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@droshev droshev added this to the Sprint 138 - September 2024 milestone Sep 23, 2024
mikerodonnell89
mikerodonnell89 requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tokens in the tokenizer do not reflect the selected items from the datasource:

Screen.Recording.2024-09-27.at.12.52.45.PM.mov

@khotcholava khotcholava marked this pull request as draft October 3, 2024 13:23
@khotcholava
fix(core): multi combobox
61294aa 
- Multi combobox value fix
@khotcholava khotcholava closed this Oct 4, 2024
@khotcholava
Copy link
Contributor Author

Need rework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 requested changes

@droshev droshev Awaiting requested review from droshev

@InnaAtanasova InnaAtanasova Awaiting requested review from InnaAtanasova

Assignees

@khotcholava khotcholava

Labels
None yet
Projects
None yet
Milestone
Sprint 139 - October 2024
Development

Successfully merging this pull request may close these issues.

Bug: Multi-Combobox selectedItems can't be updated after the first rendering
3 participants
@khotcholava @mikerodonnell89 @droshev