fix(core): toolbar render spacer before overflow conditionally #12453
+39
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit b151598): https://fundamental-ngx-gh--pr12453-fix-toolbar-spacer-bbhxy52c.web.app (expires Fri, 11 Oct 2024 00:07:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
dpavlenishvili
approved these changes
Sep 23, 2024
droshev
force-pushed
the
fix/toolbar-spacer
branch
2 times, most recently
from
84ff810
to
d0d28cd
Compare
InnaAtanasova
approved these changes
Sep 24, 2024
mikerodonnell89
requested changes
Sep 24, 2024
mikerodonnell89
approved these changes
Sep 25, 2024
droshev
modified the milestones:
Sprint 138 - September 2024,
Sprint 139 - October 2024
droshev
changed the title
droshev
force-pushed
the
fix/toolbar-spacer
branch
2 times, most recently
from
c0e010d
to
30bbfac
Compare
droshev
force-pushed
the
fix/toolbar-spacer
branch
2 times, most recently
from
7274a94
to
68dafb5
Compare
droshev
changed the title
droshev
force-pushed
the
fix/toolbar-spacer
branch
from
68dafb5
to
b151598
Compare
should be fixed now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #12239
Description
render spacer before the overflow button conditionally (only if the application doesn't have non-fixed spacer)