Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally retain custom field types #213

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Optionally retain custom field types #213

merged 5 commits into from
Sep 20, 2024

Conversation

christiand93
Copy link
Member

  • Add setting to retain custom field types when using cloud logging format
  • Update documentation accordingly
  • Fix test cases failing due to async callback called too early

@christiand93 christiand93 marked this pull request as ready for review May 28, 2024 07:01
nicklas-dohrn
nicklas-dohrn requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@nicklas-dohrn nicklas-dohrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual function looks a little bit crowded.
Besides that, only some minor oversights.

docs/general-usage/04-custom-fields.md Outdated Show resolved Hide resolved
docs/general-usage/04-custom-fields.md Outdated Show resolved Hide resolved
src/lib/logger/recordFactory.ts Outdated Show resolved Hide resolved
src/test/acceptance-test/custom-fields.test.js Outdated Show resolved Hide resolved
src/test/unit-test/config.test.js Show resolved Hide resolved
src/lib/logger/recordFactory.ts Outdated Show resolved Hide resolved
src/lib/logger/recordFactory.ts Show resolved Hide resolved
@christiand93 christiand93 linked an issue Sep 20, 2024 that may be closed by this pull request
Custom fields always converted to strings, even if not necessary. #204
Closed
nicklas-dohrn
nicklas-dohrn approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@nicklas-dohrn nicklas-dohrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christiand93 christiand93 merged commit eb6264d into main Sep 20, 2024
6 checks passed
@christiand93 christiand93 deleted the retain-custom-field-type branch September 20, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklas-dohrn nicklas-dohrn nicklas-dohrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom fields always converted to strings, even if not necessary.
2 participants
@christiand93 @nicklas-dohrn