Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Webhook - Service name length check #128

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[Misc] Webhook - Service name length check #128

merged 2 commits into from
Sep 12, 2024

Conversation

anirudhprasad-sap
Copy link
Contributor

@anirudhprasad-sap anirudhprasad-sap commented Sep 11, 2024 •
edited
Loading

With the check for the service name, no additional check for the deployment name is needed, as it will always be less than the service name.

@anirudhprasad-sap anirudhprasad-sap changed the title [Misc] Webhook - Workload name length check [Misc] Webhook - Service name length check Sep 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Pavan-SAP
Pavan-SAP approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@Pavan-SAP Pavan-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@anirudhprasad-sap anirudhprasad-sap merged commit 368127a into main Sep 12, 2024
7 checks passed
@anirudhprasad-sap anirudhprasad-sap deleted the workloadNameLenCheck branch September 12, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavan-SAP Pavan-SAP Pavan-SAP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anirudhprasad-sap @Pavan-SAP