Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] chart enhancements for version monitoring #83

Merged
merged 5 commits into from
Sep 25, 2024
Merged

[FEAT] chart enhancements for version monitoring #83

merged 5 commits into from
Sep 25, 2024

Conversation

skrishnan-sap
Copy link
Contributor

CHANGES:

  • CRD capapplicationversions enhanced with monitoring.scrapeConfig and monitoring.deletionRules
  • Controller RBAC enhanced to access CRD's and ServiceMonitors
  • Controller deployment enhanced with version monitoring environment variables

@skrishnan-sap skrishnan-sap mentioned this pull request Sep 18, 2024
Merged
@skrishnan-sap skrishnan-sap marked this pull request as ready for review September 18, 2024 12:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Pavan-SAP
Pavan-SAP approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@Pavan-SAP Pavan-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@skrishnan-sap skrishnan-sap merged commit 65812ac into main Sep 25, 2024
7 checks passed
@skrishnan-sap skrishnan-sap deleted the vers-mon branch September 25, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavan-SAP Pavan-SAP Pavan-SAP approved these changes

@anirudhprasad-sap anirudhprasad-sap Awaiting requested review from anirudhprasad-sap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skrishnan-sap @Pavan-SAP