Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMBC] Update file format 2211 #416

Merged
merged 8 commits into from
Nov 21, 2022
Merged

[SMBC] Update file format 2211 #416

merged 8 commits into from
Nov 21, 2022

Conversation

sepp4me
Copy link
Member

@sepp4me sepp4me commented Nov 2, 2022

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Nov 2, 2022

CLA assistant check
All committers have signed the CLA.

sepp4me and others added 3 commits November 2, 2022 14:54
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me sepp4me closed this Nov 2, 2022
@sepp4me sepp4me reopened this Nov 2, 2022
@schneidermic0
Copy link
Contributor

This PR contains a bigger amount of changes. Is this compatible with the existing version supported by abapGit? See abapGit/abapGit#5808

@schneidermic0 schneidermic0 self-requested a review November 7, 2022 10:42
@sepp4me
Copy link
Member Author

sepp4me commented Nov 7, 2022

This PR contains a bigger amount of changes. Is this compatible with the existing version supported by abapGit? See abapGit/abapGit#5808

This code line ensures that the SMBC object can only be used with abapGit with the file format this PR establishes.
The changes to the file format and the creation of the check class have been made in the same release

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sepp4me for the update!

Since, this is the version as already supported by abapGit, it looks good to me.

@larshp
Copy link
Collaborator

larshp commented Nov 20, 2022

validation error: will be fixed when #436 is merged

@schneidermic0 schneidermic0 merged commit 2761d15 into SAP:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants