Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds NROB #144

Merged
merged 18 commits into from
Aug 4, 2021
Merged

Adds NROB #144

merged 18 commits into from
Aug 4, 2021

Conversation

huber-nicolas
Copy link
Contributor

closes #119

huber-nicolas and others added 7 commits July 26, 2021 17:23
@huber-nicolas
Adds NROB
dd1112d
@huber-nicolas @abaplint
Update file-formats/nrob/type/if_nr_aff_nrob_v1.intf.abap
d8ddf0b 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@huber-nicolas @abaplint
Update file-formats/nrob/type/if_nr_aff_nrob_v1.intf.abap
af54fe0 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@huber-nicolas @abaplint
Update file-formats/nrob/type/if_nr_aff_nrob_v1.intf.abap
1ffde95 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@huber-nicolas
Update nrob type
e554323
@huber-nicolas
if to zif
4e94593
@huber-nicolas
master to original
28f5786
@huber-nicolas
Copy link
Contributor Author

The back-end does not yet work with the uploaded NROB Type.
The example NROB which is uploaded is hand-written and not serialized (f.ex. with out saff_testing_tool).
But the schema is generated from the uploaded NROB Type. The Abap Type (and the resulting schema) has some issues which we need to discuss

huber-nicolas
huber-nicolas commented Jul 26, 2021
View reviewed changes
file-formats/nrob/nrob.json Outdated Show resolved Hide resolved
file-formats/nrob/nrob.json Outdated Show resolved Hide resolved
file-formats/nrob/nrob.json Outdated Show resolved Hide resolved
file-formats/nrob/nrob.json Show resolved Hide resolved
albertmink
albertmink approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good to me.

schneidermic0
schneidermic0 reviewed Jul 27, 2021
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. See my comments to your questions

file-formats/nrob/nrob.json Show resolved Hide resolved
file-formats/nrob/nrob.json Outdated Show resolved Hide resolved
file-formats/nrob/nrob.json Outdated Show resolved Hide resolved
huber-nicolas and others added 5 commits August 3, 2021 10:46
@huber-nicolas
Adding Annotations to NROB Type + update schema
f9e2cbd 
adding min/max/multipleOf to
      percent_warning      TYPE p LENGTH 3 DECIMALS 1,
and adding default to
buffered_numbers TYPE n LENGTH 8
@huber-nicolas @abaplint
Update file-formats/nrob/type/zif_nr_aff_nrob_v1.intf.abap
49d5eb9 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@huber-nicolas @abaplint
Update file-formats/nrob/type/zif_nr_aff_nrob_v1.intf.abap
053e78d 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@huber-nicolas @abaplint
Update file-formats/nrob/type/zif_nr_aff_nrob_v1.intf.abap
6e00769 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@huber-nicolas
Update schema
62b93b4
@wurzka wurzka mentioned this pull request Aug 4, 2021
Merged
schneidermic0
schneidermic0 approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@huber-nicolas huber-nicolas merged commit 6a671b8 into main Aug 4, 2021
@huber-nicolas huber-nicolas deleted the Add-NROB branch August 4, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshp larshp larshp left review comments

@albertmink albertmink albertmink approved these changes

@schneidermic0 schneidermic0 schneidermic0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No ABAP type for NROB, yet
4 participants
@huber-nicolas @larshp @albertmink @schneidermic0