Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORRESPONDING ... EXCEPT and LOOP AT ... GROUP BY indentation #330

Open
vonglan opened this issue Jun 24, 2024 · 6 comments
Open

CORRESPONDING ... EXCEPT and LOOP AT ... GROUP BY indentation #330

vonglan opened this issue Jun 24, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@vonglan
Copy link

vonglan commented Jun 24, 2024

Hi Jörg-Michael,

it seems these do not work as expected (or maybe something is wrong with my ADT/installation?):

      APPEND CORRESPONDING #( group->*
                      EXCEPT mode_response_time_secs
                        mode_response_time_percentage ) TO it_agg REFERENCE INTO DATA(wa_agg). 

and

    LOOP AT it REFERENCE INTO DATA(group)
         GROUP BY ( syst = group->syst
                        begin_date = group->date_in_system_tz
                    instance = group->instance
                        tcode = group->tcode
                    progname = group->progname
                    task_type = group->task_type
                      screen_nr = group->screen_nr
                    jobname = group->jobname ). 

In both cases, I would expect the field names to be aligned.

Best regards,
Edo

@jmgrassau jmgrassau added the enhancement New feature or request label Jun 26, 2024
@jmgrassau
Copy link
Member

Hi Edo,

excellent, those cases are indeed not yet considered, thanks a lot!

Kind regards,
Jörg-Michael

@vonglan
Copy link
Author

vonglan commented Jul 1, 2024

if you want to do that, here is another:

      SPLIT line->* AT ';' INTO wak-pgmid
                              wak-object
                                wak-objname
                                wak-mastertype.

@vonglan
Copy link
Author

vonglan commented Jul 1, 2024

and it seems there is another:

          APPEND CORRESPONDING #( key->*
                                  MAPPING obj_type = object
                                  obj_name = objname ) TO object-keys.

@vonglan
Copy link
Author

vonglan commented Jul 2, 2024

and I would like to see INIT ... FOR ... NEXT aligned:

      e_leftover_qty = REDUCE #( INIT q = 0
                                      FOR <dlv> IN i_dlvs
                                   NEXT q += <dlv>-qty ).

@ConjuringCoffee
Copy link
Contributor

REDUCE is already covered by this issue: #107 😉

@jmgrassau jmgrassau self-assigned this Jul 7, 2024
jmgrassau added a commit to jmgrassau/abap-cleaner that referenced this issue Jul 8, 2024
@jmgrassau
Copy link
Member

Hi Edo,

for a start, alignment of LOOP AT ... GROUP BY ( ... ) is now supported in version 1.18.0, which was just released:

image

Kind regards,
Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants