Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize the custom error message #300

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bookshop/srv/cat-service.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class CatalogService extends cds.ApplicationService { init() {
// Validate input data
if (!book) return req.error (404, `Book #${id} doesn't exist`)
if (quantity < 1) return req.error (400, `quantity has to be 1 or more`)
if (quantity > book.stock) return req.error (409, `${quantity} exceeds stock for book #${id}`)
if (quantity > book.stock) return req.error (409, "ORDER_EXCEEDS_STOCK", [quantity, id])

// Reduce stock in database and return updated stock value
await UPDATE (Books, id) .with ({ stock: book.stock -= quantity })
Expand Down
1 change: 1 addition & 0 deletions bookshop/srv/i18n/messages.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ORDER_EXCEEDS_STOCK={0} exceeds stock for book #{1}