This repository was archived by the owner on Jun 3, 2024. It is now read-only.
adds npm install for husky #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimirs Semikins <[email protected]>
Contributor
|
Thanks for the PR, @seVladimirs ! Can you please add some description so we know what your intentions are with this? Thanks! |
seVladimirs
commented
Nov 23, 2021
Comment on lines
+15
to
+20
| ### NPM | ||
| ``` | ||
| npx husky-init && npm install | ||
| ``` | ||
|
|
||
|
|
Author
There was a problem hiding this comment.
I've simple tried to execute instruction step by step without having yarn installed and failed. this fix will include also instructions for NPM
| This sets up the formatter. Notice how it uses `set` over `add` as the second command does. This is because this was the first hook I was adding. The `set` command will overwrite all commands in the file. I also had the files format first and the unit tests run second. This is because regardless of if the unit tests pass or fail, I want my files to be formatted. If any of the commands error out, the commit will be aborted and no other hooks will be run, therefore, my unit tests are run last. | ||
| ### Yarn | ||
| ``` | ||
| yarn husky set ./husky/pre-commit "npx pretty-quick --staged" |
Author
There was a problem hiding this comment.
if you execute this line it will fail as path to husky folder is wrong, it should be .husky instead.
Author
|
@qmacro done, also commented directly in the code review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.