Compress Option

[olirogers]

Hi,

I have been using my own grunt task for a while now that does a similar thing so I merged in the code I used for Javascript, XML and JSON file minification to grunt-openui5.

I have updated the tests to include the new option and some more advanced test data. Let me know if this works for you.

Thanks,

Oli

[matz3]

Hi Oli,

thanks for sending this pull-request.

Before your pull-request can be accepted you have to agree to our CLA, see here:
https://github.com/SAP/grunt-openui5/blob/master/CONTRIBUTING.md
and here:
https://github.com/SAP/openui5/blob/master/CONTRIBUTING.md#contributor-license-agreement

Your changes are looking good to me, thanks!
But there are a few problems regarding tabs/spaces and line-endings.

Can you please convert your changes to use tabs and unix line-endings (\n)?

The tests should also be adopted to be independent of line-endings (as you could checkout the files with windows line-endings). This wasn't even the case before your changes, but as you've modified them, I guess it is easier if you change this as well (if you don't mind ;-) otherwise I can do it).
I would suggest to normalize the line-endings using grunt.util.normalizelf.

Thanks,
Matthias

[olirogers]

Hi Matthias,

Sorry it has taken me some time to get round to fixing this. I think I have managed to do so now though!

I saw you implemented a file comparison test utiliy that I re-used for my purposes also and this seems to make the tests pass on Windows.

I compressed the commits into one and also added the CLA tag as requested.

Let me know if you would like me to make any further changes.

Thanks,

Oli

[matz3]

Thanks Oli! Looks good to me!

There are 2 points that I will take care of after merging your change:

• The xml compress doesn't seem to handle html tags like <pre> correctly (which could be used in an XMLView). If one has whitespaces only, they are not preserved like it should be. In this rare case, the whole file should just be skipped.
• Copyright comments in JS files should also be preserved (in the same way like we did it in our internal build, so I will reuse our pattern).