Add more validations and refactor and improve tests. #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pitbulk
commented
Jun 1, 2015
pitbulk
commented
- Add more validations to the SAMLResponse class.
- Add more validations to the LogoutResponse class
- Add more validations to the LogoutRequest class
- Refactor and improve tests (+coverage).
|
@luisvm @Lordnibbler Can you review that 1st commit of this PR? |
|
👍 lgtm |
Closed
|
@luisvm, @Lordnibbler, can you validate this PR to be merged? |
|
👍 |
pitbulk
added a commit
that referenced
this pull request
Jun 5, 2015
Add more validations and refactor and improve tests.
This was referenced Feb 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.