Fixes #112 and #117 in a backwards compatible manner #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AttributeValue is a String, but `AttributeValue#values` will return all values for that attribute.
|
@borgand Did you get any notification about some comment I made on you commit about an issue with some corner case on multiple-attribute-values ? |
|
@sebastienluquet I do not believe I did. Where can I find it? |
|
I have created a separate pull-request #135 to handle @sebastienluquet's comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a class
AttributeValuethat is a subclass ofStringso that for all current usage, the last attribute value is still returned as string.But when needed,
AttributeValue#valueswill return an array of all values. This fixes both #112 and #117As current implementation returns last value as seen from XML, this patch returns attributes in reverse order when compared to XML to retain compatibility with specs for other libraries.