Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable additional SP metadata #433

Closed
bmesuere opened this issue Jan 17, 2018 · 4 comments · Fixed by #602
Closed

enable additional SP metadata #433

bmesuere opened this issue Jan 17, 2018 · 4 comments · Fixed by #602

Comments

@bmesuere
Copy link

My idp requires me to add additional fields (e.g. Organization, ContactPerson, ...) to my metadata before I can register my SP with them.

Is there a way to add these to the generated metadata?

@pitbulk
Copy link
Collaborator

pitbulk commented Jan 17, 2018

Not supported.

You will need to extend the Metadata class

@bmesuere
Copy link
Author

Thanks for your quick reply. It would be easier to extend this if generate was split into 2 separate methods: 1 to generate the document and 1 to sign and convert to string. The only way to do it right now is to effectively copy the existing code and add a few tags, which is not very future proof.

@pitbulk
Copy link
Collaborator

pitbulk commented Jan 17, 2018

Yes other toolkits (php-saml, python-saml) have generation and sign separated.

Right now I see 2 alternatives:

  • Extend generate method to accept contact and organization objects that will include info on the metadata.
  • Extract the sign on a new static method and add a flag to sign or not the metadata calling the method we previously created, add another method that add contact and organization to the metadata.

if you implement that for your project and can provide a PR with unit test would be great.

johnnyshields added a commit to johnnyshields/ruby-saml that referenced this issue Aug 7, 2021
…ass so it is easier to extend by breaking it into a series of methods. Also adds the #add_extras convenience method which is empty but can be extended. No change to behavior.
@johnnyshields
Copy link
Collaborator

I've raised a PR to fix this issue: #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants