Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyDescriptor node requires signing attribute when it is optional in spec #299

Closed
wGEric opened this issue Jan 22, 2016 · 0 comments
Closed

KeyDescriptor node requires signing attribute when it is optional in spec #299

wGEric opened this issue Jan 22, 2016 · 0 comments

Comments

@wGEric
Copy link

wGEric commented Jan 22, 2016

To get the certificate from a metdata file, this library looks for a KeyDescriptor node with the signing attribute. According to the saml spec, this attribute is optional. If you choose to not include this attribute then the metadata parser won't find the certificate.
alex-wood added a commit to alex-wood/ruby-saml that referenced this issue Apr 26, 2016
@alex-wood
Merge remote-tracking branch 'onelogin/master'
9847ff6 
* onelogin/master:
  Explictly state Ruby 2.0.x support
  Related to PR SAML-Toolkits#269
  Fix SAML-Toolkits#299
  Fix SAML-Toolkits#306. Support WantAssertionsSigned
  Use settings.idp_cert_fingerprint_algorithm in idp_metadata_parser for fingerprint instead of SHA1
  Implement binding parsing in idp_metadata_parser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wGEric