Merge pull request #624 from SAFE-Stack/return-full-todo-list

Change the api to return full TODO list after adding todo
SAFE-Stack · Aug 16, 2024 · dc30e03 · dc30e03
2 parents 304f192 + 0c4071a
commit dc30e03
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/Content/default/src/Client/Index.fs b/Content/default/src/Client/Index.fs
@@ -12,7 +12,7 @@ type Model = {
 type Msg =
     | SetInput of string
     | LoadTodos of ApiCall<unit, Todo list>
-    | SaveTodo of ApiCall<string, Todo>
+    | SaveTodo of ApiCall<string, Todo list>
 
 let todosApi = Api.makeProxy<ITodosApi> ()
 
@@ -40,10 +40,10 @@ let update msg model =
                 Cmd.OfAsync.perform todosApi.addTodo todo (Finished >> SaveTodo)
 
             { model with Input = "" }, saveTodoCmd
-        | Finished todo ->
+        | Finished todos ->
             {
                 model with
-                    Todos = model.Todos |> RemoteData.map (fun todos -> todos @ [ todo ])
+                    Todos = RemoteData.Loaded todos
             },
             Cmd.none
 

diff --git a/Content/default/src/Server/Server.fs b/Content/default/src/Server/Server.fs
@@ -25,7 +25,7 @@ let todosApi ctx = {
         fun todo -> async {
             return
                 match Storage.addTodo todo with
-                | Ok() -> todo
+                | Ok() -> Storage.todos |> List.ofSeq
                 | Error e -> failwith e
         }
 }

diff --git a/Content/default/src/Shared/Shared.fs b/Content/default/src/Shared/Shared.fs
@@ -15,5 +15,5 @@ module Todo =
 
 type ITodosApi = {
     getTodos: unit -> Async<Todo list>
-    addTodo: Todo -> Async<Todo>
+    addTodo: Todo -> Async<Todo list>
 }
diff --git a/Content/default/tests/Client/Client.Tests.fs b/Content/default/tests/Client/Client.Tests.fs
@@ -12,8 +12,7 @@ let client =
         <| fun _ ->
             let newTodo = Todo.create "new todo"
             let model, _ = init ()
-            let model, _ = update (LoadTodos (Finished [])) model
-            let model, _ = update (SaveTodo(Finished newTodo)) model
+            let model, _ = update (SaveTodo(Finished [ newTodo ])) model
 
             Expect.equal
                 (model.Todos |> RemoteData.map _.Length |> RemoteData.defaultValue 0)
@@ -30,13 +29,13 @@ let client =
 
 let all =
     testList "All" [
-//-:cnd:noEmit
+        //-:cnd:noEmit
 #if FABLE_COMPILER // This preprocessor directive makes editor happy
         Shared.Tests.shared
 #endif
-//+:cnd:noEmit
+        //+:cnd:noEmit
         client
     ]
 
 [<EntryPoint>]
-let main _ = Mocha.runTests all
+let main _ = Mocha.runTests all