Chore/replace iam serice with authentication service #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wysher
force-pushed
the
chore/replace-iam-serice-with-authentication-service
branch
from
c54f9d0
to
117fac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since I started using your template, I thought I could do some cleanup that others might benefit from as well.
I discovered that there are two services performing the same task and both are in use - IamService and AuthenticationService, with the latter being newer. Therefore, I removed the old one and replaced it with AuthenticationService.
If you'd prefer to do it the other way around, let me know.
EDIT:
I also discovered that verifyEmail gets 404, there was wrong method used.