-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Skip First Run option #8
Add Skip First Run option #8
Conversation
Any plans to merge this? Been using it for a while with no trouble. |
👍 I would love to see this merged. It was not immediately obvious that all jobs would be run on deploy even if |
We've tried this out over the last few days and we have found the following issues:
|
Thanks Marc, will look into fixes for those issues later today :) |
Maintainer of clockwork-test here. I'm on vacation, so I can't take a look now at the correlation that causes the gem to fail with this change. However, that's on us to figure out & maintain, so don't let it hold up development here. PRs or advise on maintaining compatibility are always welcome! Thanks for taking a look at it @MarcLapierre. |
Hey guys -- I am looking for a follow-up here. Are we looking at resolving and merging this? |
@kevin-j-m thanks, I misread that comment, thought it was breaking tests in the main clockwork gem. I'm not sure how to move this forward at this point :/ |
@ChaoticBoredom Could you add some documentation to the README ? Thanks ;) |
@Rykian sorry for the delay, updated the README, let me know if more detail is needed, or if there's a section I've missed :) |
Let's go! |
Hey @ChaoticBoredom -- Did we ever resolve the issue around |
@MarcLapierre sorry for the delay, that was not addressed. Also, until today I misunderstood how clockwork worked using |
Working w/ clockwork on Heroku, we often want to delay the first run of some jobs on deploys. Usually things like metric collection, particularly those triggering alerts. If they are run at the moment of deploy, they return bad data.
We'd like to delay the first run of these alerts for a single cycle.
I'm putting this PR up, not sure how in demand this particular feature is, but I'm open to alternatives if this isn't the route the maintainer wants to go.