build(packages/py): restructure for PyPI publishing - #403
Conversation
…hon lib * This broke example-apps/console-py, so a follow up commit is necessary to fix it
WalkthroughRoot ChangesBuild Configuration Consolidation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pyproject.toml`:
- Line 26: The inline comment "Python package lives HERE (unchanged code
location)" in pyproject.toml is misleading; either remove that comment entirely
or replace it with a correct clarification referencing the actual location of
the Python sources (e.g., that source packages are under packages/py/img2num/).
Locate the exact comment string "Python package lives HERE (unchanged code
location)" and delete or update it so the file no longer suggests the package is
in the repository root.
- Around line 1-8: The [project] section in pyproject.toml is missing essential
metadata required for PyPI; update the [project] table by adding a license field
(e.g., SPDX identifier via license = { text = "..." } or license-expression), a
readme entry pointing to your README file and content-type, authors or
maintainers list with names and emails, a classifiers array (development status,
intended audience, license, Python versions), and a urls table with
repository/homepage/docs links; also replace the placeholder version = "0.0.0"
with the actual release version before publishing.
- Around line 11-15: Pin and constrain NumPy in both the build-system and
project dependencies: update the "numpy" entry in [build-system].requires and
the "numpy" entry in [project].dependencies to a specific constrained range
(e.g. "numpy>=<min_supported>,<<=optional_upper>") so the PEP 517 isolated build
environment uses the same compatible NumPy as runtime; ensure the same version
spec is used in both the requires list and the dependencies list.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 36bd8d7b-9536-4170-9b19-89de8dc933df
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
packages/py/pyproject.tomlpyproject.toml
💤 Files with no reviewable changes (1)
- packages/py/pyproject.toml
📜 Review details
⏰ Context from checks skipped due to timeout of 120000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Build C/C++ / Build WASM (bindings/js)
- GitHub Check: Build C/C++ / Build Python
- GitHub Check: Build C/C++ / Build C & C++
- GitHub Check: Build Documentation Site / Build Docusaurus Site
- GitHub Check: Lint & Validate Code
- GitHub Check: Analyze (c-cpp)
🔇 Additional comments (2)
pyproject.toml (2)
36-43: LGTM!
45-68: LGTM!
ab65c7f to
6f8946c
Compare
74b7238 to
fb02440
Compare
|
Actionable comments posted: 0 |
|
Hi @Krasner I have moved the Python package to be at the root because You can see what I mean here: scikit-build/scikit-build-core#647 |
|
@coderabbitai suggest a conventional commit and description. |
|
Tip For best results, initiate chat on the files or code changes.
Subject line: Full commit message: A few notes:
|
What was changed & why
packages/py/pyproject.tomland similar were updated to build from the root to enable smootherscikit-build-corebuilds that are ready for publishing to PyPI.Fixes: none
Motivation: scikit-build/scikit-build-core#647
Changes
Testing & Verification
Additional Resources