docs: add a warning to Setup & Dependencies docs about Git submodules - #350
Conversation
WalkthroughAdded a warning admonition to the "Clone the repository" section explaining missing submodules when cloning without ChangesSubmodule initialization doc update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/docs/contributing/setup-and-dependencies/index.md`:
- Around line 39-50: The warning admonition block closes immediately after the
fenced code block which violates markdownlint MD031; edit the admonition that
starts with ":::warning" and add a single blank line between the closing ```
fence and the closing ":::". Ensure there is exactly one empty line inserted
between the code fence and the admonition terminator so the block becomes:
opening ":::warning", the fenced code block, a blank line, then the closing
":::".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 94eb9d55-6603-44da-9105-3d4850cd150e
📒 Files selected for processing (1)
docs/docs/contributing/setup-and-dependencies/index.md
📜 Review details
🧰 Additional context used
📓 Path-based instructions (2)
**/*.md
📄 CodeRabbit inference engine (.editorconfig)
**/*.md: Do not trim trailing whitespace in Markdown files
Use 2-space indentation for Markdown files
Do not enforce maximum line length for Markdown files
Files:
docs/docs/contributing/setup-and-dependencies/index.md
docs/docs/**
⚙️ CodeRabbit configuration file
docs/docs/**: All documentation must follow Docusaurus conventions (docs/docs/ folder structure).
Do NOT suggest creating strangely-named markdown files at the repository root
(e.g. COMPREHENSIVE_TEST_REPORT.md, DELIVERABLES.md, SUMMARY.md).
New docs belong either as a dedicated Docusaurus category or integrated into an
existing category such as project-scripts. Verify valid frontmatter
(title, sidebar_label, etc.) and correct sidebar wiring.
Files:
docs/docs/contributing/setup-and-dependencies/index.md
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
Repo: Ryan-Millard/Img2Num
Timestamp: 2026-05-04T09:43:57.481Z
Learning: Clone the repository using the `--recursive` flag to ensure the `third_party/stb` submodule is included
Learnt from: CR
Repo: Ryan-Millard/Img2Num
Timestamp: 2026-05-04T09:43:57.481Z
Learning: Use Docker dev environment for development instead of local setup
Learnt from: CR
Repo: Ryan-Millard/Img2Num
Timestamp: 2026-05-04T09:43:57.481Z
Learning: Use the `img2num` script wrapper (sh, bash, or shell commands) for running scripts inside the Docker environment
Learnt from: CR
Repo: Ryan-Millard/Img2Num
Timestamp: 2026-05-04T09:43:57.481Z
Learning: Run all CMake commands from the root of the project
Learnt from: CR
Repo: Ryan-Millard/Img2Num
Timestamp: 2026-05-04T09:43:57.481Z
Learning: Compile WebAssembly using Emscripten with `emcmake cmake` before using the JavaScript library and example apps
Learnt from: CR
Repo: Ryan-Millard/Img2Num
Timestamp: 2026-05-04T09:43:57.481Z
Learning: Install JavaScript dependencies using `pnpm install` before running documentation, packages, and example apps
Learnt from: CR
Repo: Ryan-Millard/Img2Num
Timestamp: 2026-05-04T09:43:57.481Z
Learning: Use `pnpm -F <workspace>` command to run scripts within specific workspace packages
Learnt from: CR
Repo: Ryan-Millard/Img2Num
Timestamp: 2026-05-04T09:43:57.481Z
Learning: Verify Git and Docker prerequisite installations using `git --version` and `docker --version`
📚 Learning: 2026-01-04T15:34:04.654Z
Learnt from: Ryan-Millard
Repo: Ryan-Millard/Img2Num PR: 146
File: docs/docs/reference/react/components/ThemeSwitch/tests.md:123-124
Timestamp: 2026-01-04T15:34:04.654Z
Learning: In Docusaurus documentation, relative directory links (e.g., ../ or ../../../hooks/useTheme) resolve to index.md within the target directory. Do not require or force linking to index.md explicitly; such relative links remain valid and should not be changed when reviewing docs under the docs directory.
Applied to files:
docs/docs/contributing/setup-and-dependencies/index.md
📚 Learning: 2026-02-22T15:20:15.304Z
Learnt from: Ryan-Millard
Repo: Ryan-Millard/Img2Num PR: 263
File: docs/docs/internal/core/api-reference.md:13-13
Timestamp: 2026-02-22T15:20:15.304Z
Learning: In Docusaurus projects, Markdown files (*.md, *.mdx) may contain anchor tags with onClick={(e) => { e.preventDefault(); window.location.href = '...'; }} to force a full page navigation, bypassing React SPA routing for static/external paths. Treat this as intentional and do not flag it as redundant in docs contexts. Apply this guidance broadly to Markdown docs across the repository (not just the single file) and focus reviews on more impactful patterns such as accessibility, SEO, and navigation consistency.
Applied to files:
docs/docs/contributing/setup-and-dependencies/index.md
🪛 markdownlint-cli2 (0.22.1)
docs/docs/contributing/setup-and-dependencies/index.md
[warning] 49-49: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
|
Thank you for the update! Our docs are definitely in need of some big updates. |
Closes #343
Summary
Adds a warning admonition to the Setup & Dependencies documentation for contributors who clone the repository without the
--recursiveflag, leaving thethird_party/stbsubmodule uninitialised.Problem
When cloning without
--recursive,third_party/stbis an empty directory on the host machine. Since the Docker dev container mounts the project directory, it sees the same empty folder, causing the Python bindings build to fail with:This was discovered during setup in #341 (now reopened as another issue). The clone command in the docs already includes
--recursive, but there was no guidance for contributors who had already cloned without it.Fix
Added a
:::warningadmonition block directly beneath the clone command indocs/docs/contributing/setup-and-dependencies/index.mdexplaining the symptom and the recovery command:Related