Skip to content

fix(docker-ci): fix docker image cleanup after PR closure - #323

Closed
Ryan-Millard wants to merge 1 commit into
mainfrom
fix/ci/docker-image-pr-cleanup
Closed

fix(docker-ci): fix docker image cleanup after PR closure#323
Ryan-Millard wants to merge 1 commit into
mainfrom
fix/ci/docker-image-pr-cleanup

Conversation

@Ryan-Millard

@Ryan-Millard Ryan-Millard commented Apr 22, 2026

Copy link
Copy Markdown
Owner

Previously failed to delete the images,
see https://github.com/Ryan-Millard/Img2Num/actions/runs/24804191793/job/72594225429.

What was changed & why

Cleanup job in docker-ci.yml was updated - lets hope it works.

Fixes: #none - see here.

Changes

Simple job update

Testing & Verification

Additional Resources

Summary by CodeRabbit

  • Chores
    • Updated CI/CD configuration to refine container registry cleanup policies and improve workflow efficiency.

@coderabbitai

coderabbitai Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@Ryan-Millard has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 29 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 29 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ba7cacf3-af5d-4dc9-bb19-e8168541bb6a

📥 Commits

Reviewing files that changed from the base of the PR and between 8ea6b19 and eb83619.

📒 Files selected for processing (1)
  • .github/workflows/docker-ci.yml
📝 Walkthrough

Walkthrough

Updates the GitHub Actions Docker CI workflow to replace deletion policy configuration with explicit delete-only-untagged-versions: false, modify regex patterns for version filtering in cleanup steps, and switch the PR number source from workflow outputs to direct GitHub event context while preserving version tag exclusions for PR-related images.

Changes

Cohort / File(s) Summary
Docker CI Workflow Cleanup
.github/workflows/docker-ci.yml
Replaces num-old-versions-to-delete and min-versions-to-keep with delete-only-untagged-versions: false; updates ignore-versions regex patterns with ).*.* termination; switches PR number source from needs.guard.outputs.pr_number to github.event.pull_request.number in command-driven cleanup while maintaining pr-{PR} and cache-pr-{PR} version exemptions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Krasner

Poem

🐰 Hops through the registry with glee,
Old versions swept and cleanup free,
PR tags spared from deletion's call,
The workflow hops—no dupes at all! 🎯

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci/docker-image-pr-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Ryan-Millard

Copy link
Copy Markdown
Owner Author

/docker-build baddb86

@github-actions

Copy link
Copy Markdown
Contributor

🐳 Docker image built successfully!

Image

ghcr.io/ryan-millard/img2num-dev:pr-323

Run it locally:

IMG2NUM_IMAGE=ghcr.io/ryan-millard/img2num-dev:pr-323 ./img2num sh

@Ryan-Millard Ryan-Millard reopened this Apr 22, 2026
@Ryan-Millard
Ryan-Millard force-pushed the fix/ci/docker-image-pr-cleanup branch from baddb86 to 61fcdb5 Compare April 22, 2026 22:15
@Ryan-Millard Ryan-Millard reopened this Apr 22, 2026
@Ryan-Millard
Ryan-Millard force-pushed the fix/ci/docker-image-pr-cleanup branch from 61fcdb5 to eb83619 Compare April 22, 2026 22:17
@Ryan-Millard Ryan-Millard reopened this Apr 22, 2026
@Ryan-Millard

Copy link
Copy Markdown
Owner Author

/docker-cleanup

1 similar comment
@Ryan-Millard

Copy link
Copy Markdown
Owner Author

/docker-cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant