-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deadlock on supplementary nodes #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,6 +1,6 @@ | |||
Pod::Spec.new do |s| | |||
s.name = 'RxASDataSources' | |||
s.version = '0.3.4' | |||
s.version = '0.4.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please revert pod version or help to combine with PR #35 for version 0.4 that supports Swift 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dangthaison91 Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @foxware00 for your supporting.
Thanks a lot for contributing @foxware00! I've invited you to join the Generated by 🚫 dangerJS |
No problem. Are you able to make it available via cocoapods |
@foxware00 just pushed version
|
@dangthaison91 Thank you for the quick turnaround! |
I've been playing with
configureSupplementaryView
on CollectionNode and it setsASCollectionSectionedDataSource.configureSupplementaryViewBlockNotSet
which calls through toDispatchQueue.main.sync
which quite frequently causes dealocks on the main thread. I noticed a discussion in #23 that applied this fix to theconfigureCellBlockNotSet
method. This change simply prevents the deadlock which applying the same changes asconfigureCellBlockNotSet
. I wasn't 100% sure why theNotSet
methods are being called when I haven't configured the datasource to use block method.