Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock on supplementary nodes #36

Merged
merged 5 commits into from
Sep 2, 2019
Merged

Deadlock on supplementary nodes #36

merged 5 commits into from
Sep 2, 2019

Conversation

foxware00
Copy link
Contributor

I've been playing with configureSupplementaryView on CollectionNode and it sets ASCollectionSectionedDataSource.configureSupplementaryViewBlockNotSet which calls through to DispatchQueue.main.sync which quite frequently causes dealocks on the main thread. I noticed a discussion in #23 that applied this fix to the configureCellBlockNotSet method. This change simply prevents the deadlock which applying the same changes as configureCellBlockNotSet. I wasn't 100% sure why the NotSet methods are being called when I haven't configured the datasource to use block method.

Copy link
Collaborator

@dangthaison91 dangthaison91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'RxASDataSources'
s.version = '0.3.4'
s.version = '0.4.1'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert pod version or help to combine with PR #35 for version 0.4 that supports Swift 5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@dangthaison91 dangthaison91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @foxware00 for your supporting.

@dangthaison91 dangthaison91 merged commit 0e6eea7 into RxSwiftCommunity:master Sep 2, 2019
@rxswiftcommunity
Copy link

Thanks a lot for contributing @foxware00! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@foxware00
Copy link
Contributor Author

Thanks @foxware00 for your supporting.

No problem. Are you able to make it available via cocoapods

@dangthaison91
Copy link
Collaborator

dangthaison91 commented Sep 2, 2019

@foxware00 just pushed version 0.4.1

 🎉  Congrats

 🚀  RxASDataSources (0.4.1) successfully published
 📅  September 2nd, 16:46
 🌎  https://cocoapods.org/pods/RxASDataSources
 👍  Tell your friends!

@foxware00
Copy link
Contributor Author

@dangthaison91 Thank you for the quick turnaround!

@foxware00 foxware00 mentioned this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants