-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build failure on New Build System (default on Xcode 10) #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, makes sense! Can you add a note to the changelog?
@ashfurrow |
@gin0606 + @ashfurrow I guess this is already done in PR 153 |
@bobgodwinx No I think this is still required. The other one was just updating to Swift 4.2. In our project we have RxSwift as a dependency as well as Action obviously. And using 3.7 (that includes the upgrade to Swift 4.2) I'm still unable to build our project. As I understand, this seems to lead to the problem described in RxSwiftCommunity/RxDataSources#237 that the new build system is trying to build Rx twice (one time from our |
Thanks a lot for contributing @gin0606! I've invited you to join the Generated by 🚫 dangerJS |
I have released this as 3.8.0 but I think Carthage sometimes gets confused between git tags and GitHub releases. @bobgodwinx would you be free to draft up a GitHub release? |
I’l Do that on the weekend. I am currently on a work trip. |
@ashfurrow @bobgodwinx Actually I can also take care of that. It's only about writing a summary of changes, right? I don't see prebuilt binaries attached on previous releases. |
Correct, thanks! |
✅ done. |
same reason as RxSwiftCommunity/RxDataSources#237