Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure on New Build System (default on Xcode 10) #151

Merged
merged 4 commits into from
Sep 19, 2018

Conversation

gin0606
Copy link
Contributor

@gin0606 gin0606 commented Sep 18, 2018

Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, makes sense! Can you add a note to the changelog?

@gin0606
Copy link
Contributor Author

gin0606 commented Sep 19, 2018

@ashfurrow
I Update changelog.
thx

@bobgodwinx
Copy link
Member

@gin0606 + @ashfurrow I guess this is already done in PR 153

@mAu888
Copy link
Contributor

mAu888 commented Sep 19, 2018

@bobgodwinx No I think this is still required. The other one was just updating to Swift 4.2. In our project we have RxSwift as a dependency as well as Action obviously. And using 3.7 (that includes the upgrade to Swift 4.2) I'm still unable to build our project. As I understand, this seems to lead to the problem described in RxSwiftCommunity/RxDataSources#237 that the new build system is trying to build Rx twice (one time from our Cartfile and the the one referred to from the Action.xcworkspace).

@ashfurrow ashfurrow merged commit 14dbbcb into RxSwiftCommunity:master Sep 19, 2018
@rxswiftcommunity
Copy link

Thanks a lot for contributing @gin0606! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@ashfurrow
Copy link
Member

I have released this as 3.8.0 but I think Carthage sometimes gets confused between git tags and GitHub releases. @bobgodwinx would you be free to draft up a GitHub release?

@bobgodwinx
Copy link
Member

I’l Do that on the weekend. I am currently on a work trip.

@mAu888
Copy link
Contributor

mAu888 commented Sep 20, 2018

@ashfurrow @bobgodwinx Actually I can also take care of that. It's only about writing a summary of changes, right? I don't see prebuilt binaries attached on previous releases.

@ashfurrow
Copy link
Member

Correct, thanks!

@mAu888
Copy link
Contributor

mAu888 commented Sep 20, 2018

✅ done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants