Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #12

Merged
merged 3 commits into from
Dec 7, 2015
Merged

Merge #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7de45c6
Use unbounded ReplaySubject
nanoxd Dec 7, 2015
4b0b586
Updated tests.
ashfurrow Dec 7, 2015
3f3af03
Updated changelog.
ashfurrow Dec 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Action.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,7 @@ public extension Action {
public func execute(input: Input) -> Observable<Element> {

// Buffer from the work to a replay subject.
// TODO: The buffer size is set to ten because ten is "big enough"
// We're tracking this here: https://github.com/ashfurrow/Action/issues/3
let buffer = ReplaySubject<Element>.create(bufferSize: 10)
let buffer = ReplaySubject<Element>.createUnbounded()

// See if we're already executing.
var startedExecuting = false
Expand Down
5 changes: 4 additions & 1 deletion Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ Changelog
Current master
--------------

Nothing yet!
0.4.0
-----

- Unbounded replaying of event values (see [#3](https://github.com/ashfurrow/Action/issues/3)).

0.3.0
-----
Expand Down
2 changes: 1 addition & 1 deletion Demo/DemoTests/ButtonTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class ButtonTests: QuickSpec {
// Normally I'd use subject.sendActionsForControlEvents(.TouchUpInside) but it's not working
for target in subject.allTargets() {
for action in subject.actionsForTarget(target, forControlEvent: .TouchUpInside) ?? [] {
target.performSelector(Selector(action))
target.performSelector(Selector(action), withObject: subject)
}
}

Expand Down
16 changes: 8 additions & 8 deletions Demo/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
PODS:
- Action (0.2.0):
- Action (0.3.0):
- RxCocoa (~> 2.0.0-beta)
- RxSwift (~> 2.0.0-beta)
- Nimble (3.0.0)
- Quick (0.8.0)
- RxBlocking (2.0.0-beta.3):
- RxBlocking (2.0.0-beta.4):
- RxSwift (~> 2.0.0-beta)
- RxCocoa (2.0.0-beta.3):
- RxCocoa (2.0.0-beta.4):
- RxSwift (~> 2.0.0-beta)
- RxSwift (2.0.0-beta.3)
- RxSwift (2.0.0-beta.4)

DEPENDENCIES:
- Action (from `../`)
Expand All @@ -23,11 +23,11 @@ EXTERNAL SOURCES:
:path: "../"

SPEC CHECKSUMS:
Action: 836da3ae9615435467a3d1cddd384f4ea6036ba2
Action: da3ac4ae245c10f909fd07db34680a90beb4aa21
Nimble: 4c353d43735b38b545cbb4cb91504588eb5de926
Quick: 563d0f6ec5f72e394645adb377708639b7dd38ab
RxBlocking: 331f8bdedf77198f8ff1a37f09c492f1f4f631e5
RxCocoa: 1472006304b296d03c847f78b21384523cc4902e
RxSwift: 19fbe885b404d1d36d42ac8535134739a9b42952
RxBlocking: 234b0c161315ff3ade25c11e48d74e9ca83158b5
RxCocoa: 4a3e433e6dfe116362ff54423c841cc0f209e009
RxSwift: 191c6b06da783a8671433cf35a54d2ad2fd2d9de

COCOAPODS: 0.39.0