Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unbounded ReplaySubject #11

Merged
merged 1 commit into from
Dec 7, 2015
Merged

Use unbounded ReplaySubject #11

merged 1 commit into from
Dec 7, 2015

Conversation

nanoxd
Copy link
Collaborator

@nanoxd nanoxd commented Dec 7, 2015

Fixes #3 by using RxSwift's newly included createUnbounded() factory
method for ReplaySubject.

@nanoxd
Use unbounded ReplaySubject
7de45c6 
Fixes RxSwiftCommunity#3 by using RxSwift's newly included `createUnbounded()` factory
method.
@nanoxd
Copy link
Collaborator Author

nanoxd commented Dec 7, 2015

Looks like the test fail on ButtonTests's executes the action when tapped test. It fails on
buttontests swift 2015-12-06 20-41-47

The action variable holds a Selector of "eventHandler:". I ran the tests before and after the update and received the same results.

@ashfurrow
Copy link
Member

It's possible this is a change from RxSwift's beta. I'll take a look – thanks for the PR!

@ashfurrow ashfurrow mentioned this pull request Dec 7, 2015
Merged
@ashfurrow
Copy link
Member

Found the culprit! The action had a parameter added – fixed in ashfurrow@4b0b586

I'll get this merged in and released, thanks again!

@ashfurrow ashfurrow merged commit 7de45c6 into RxSwiftCommunity:master Dec 7, 2015
@nanoxd
Copy link
Collaborator Author

nanoxd commented Dec 7, 2015

💯 Good catch, thanks.

@ashfurrow
Copy link
Member

Cool, thanks for your contribution! We've now been able to release a 1.0: https://raw.githubusercontent.com/CocoaPods/Specs/233aee90a998cf01a501fa357ddfef49622847fd/Specs/Action/1.0.0/Action.podspec.json

Additionally, we'll be able to move forward on this: RxSwiftCommunity/contributors#4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanoxd @ashfurrow