Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify os window check logic in test code #1627

Closed
wants to merge 1 commit into from
Closed

Modify os window check logic in test code #1627

wants to merge 1 commit into from

Conversation

khg0712
Copy link

@khg0712 khg0712 commented Dec 14, 2019 •
edited
Loading

current os check logic in test code can't distinguish window and unix.
I solve this problem and make code more clearly

youknowone
youknowone previously approved these changes Dec 14, 2019
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@khg0712 khg0712 changed the title modify os window chk logic Modify os window check logic in test code Dec 14, 2019
@youknowone youknowone dismissed their stale review December 14, 2019 07:56

windows error

@youknowone youknowone closed this Feb 24, 2023
@youknowone
Copy link
Member

I am sorry to not to finish this on time. but this is now outdated too much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khg0712 @youknowone