Fix deriving ZeroizeOnDrop on items with generics
#787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
changed the title
ZeroizeOnDrop on fields with BoxZeroizeOnDrop on items with generics
daxpedda
force-pushed
the
zeroize-on-drop-box
branch
from
c49f779 to
57e9868
Compare
Member
|
Thanks! |
This was referenced Nov 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't actually know how to test this, because you can't access the dropped memory of a
Boxwithout a custom allocator I suppose (EDIT: same forVec). So I just made sure it builds.I'm also not a 100% sure my assumption is correct, but as far as I understand any
Dropbounds are truly unnecessary in this case.Fixes #786.