Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new_with_init_block #195

Merged
merged 8 commits into from
Feb 1, 2024
Merged

add new_with_init_block #195

merged 8 commits into from
Feb 1, 2024

Conversation

makavity
Copy link
Contributor

Add creation function for init_block, needed for belt-dwp AEAD
https://rustcrypto.zulipchat.com/#narrow/stream/260038-AEADs/topic/belt-dwp/near/418639333

tarcieri
tarcieri reviewed Jan 31, 2024
View reviewed changes
polyval/src/backend/soft64.rs Outdated
@@ -94,7 +104,7 @@ impl Drop for Polyval {

/// 2 x `u64` values
#[derive(Copy, Clone, Debug, Default, Eq, PartialEq)]
struct U64x2(u64, u64);
pub struct U64x2(u64, u64);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This visibility change doesn't seem necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that was for debug :)

@tarcieri
Copy link
Member

I'd suggest changing the definitions of new so they just call new_with_init_block and pass 0

@makavity
Copy link
Contributor Author

I'd suggest changing the definitions of new so they just call new_with_init_block and pass 0

Okay, sounds fine, will change it

@makavity
Copy link
Contributor Author

makavity commented Feb 1, 2024

Hey. Fixed new signature (calling new_with_init_block) and all platforms.

@tarcieri
Copy link
Member

tarcieri commented Feb 1, 2024

This includes a lot of superfluous changes to imports which seem unnecessary, moving them around and adding various whitespace where ordinarily we use the rustfmt ordering for imports.

@makavity
Copy link
Contributor Author

makavity commented Feb 1, 2024

This includes a lot of superfluous changes to imports which seem unnecessary, moving them around and adding various whitespace where ordinarily we use the rustfmt ordering for imports.

It is weird, because i just only use cargo fmt.

@tarcieri tarcieri merged commit 6d51e01 into RustCrypto:master Feb 1, 2024
29 checks passed
@tarcieri tarcieri mentioned this pull request Feb 29, 2024
Merged
baloo added a commit to baloo/universal-hashes that referenced this pull request Mar 3, 2024
@baloo
polyval v0.6.2
0b1de2e 
Added
- add `new_with_init_block` (RustCrypto#195)

Changed
- implement Karatsuba multiplication for arm64 (RustCrypto#181)
@baloo baloo mentioned this pull request Mar 3, 2024
Merged
baloo added a commit to baloo/universal-hashes that referenced this pull request Mar 3, 2024
@baloo
ghash v0.5.1
d9af633 
Added
- add `new_with_init_block` (RustCrypto#195)
@baloo baloo mentioned this pull request Mar 3, 2024
Merged
tarcieri pushed a commit that referenced this pull request Mar 3, 2024
@baloo
polyval v0.6.2 (#197)
4e7d04f 
Added
- add `new_with_init_block` (#195)

Changed
- implement Karatsuba multiplication for arm64 (#181)
baloo added a commit to baloo/universal-hashes that referenced this pull request Mar 3, 2024
@baloo
ghash v0.5.1
4741fa4 
Added
- add `new_with_init_block` (RustCrypto#195)
baloo added a commit to baloo/universal-hashes that referenced this pull request Mar 3, 2024
@baloo
ghash v0.5.1
e41b547 
Added
- add `new_with_init_block` (RustCrypto#195)
tarcieri pushed a commit that referenced this pull request Mar 3, 2024
@baloo
ghash v0.5.1 (#198)
655c6cb 
Added
- add `new_with_init_block` (#195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makavity @tarcieri