Remove implementations of the VariableOutput trait
#744
+34
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
makavity
pushed a commit
to makavity/hashes
that referenced
this pull request
Nov 4, 2025
tarcieri
added a commit
that referenced
this pull request
Nov 5, 2025
Restores hashes that previously impl'd the now removed `VariableOutput` trait which were removed in #744. They're used by `argon2`. Note the API has been transition from traits to inherent methods, and the implementations have not been restored for other runtime-variable hash functions, just `blake2` due to the need to use `Blake2bVar` in the `argon2` crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on RustCrypto/traits#2043