Skip to content

To use avx2, both avx and avx2 must be checked. #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brocaar wants to merge 2 commits into from
Closed

To use avx2, both avx and avx2 must be checked. #386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cd3f21
To use avx2, both avx and avx2 must be checked.
brocaar Aug 16, 2022
fcb9cf4
Combine avx and avx2 check. Add reference to PR.
brocaar Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sha2/src/sha512/x86.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ use core::arch::x86_64::*;

use crate::consts::K64;

cpufeatures::new!(avx2_cpuid, "avx2");
// We need to check availability of both AVX and AVX2, see:
// https://github.com/RustCrypto/hashes/pull/386
cpufeatures::new!(avx2_cpuid, "avx", "avx2");

pub fn compress(state: &mut [u64; 8], blocks: &[[u8; 128]]) {
// TODO: Replace with https://github.com/rust-lang/rfcs/pull/2725
Expand Down