fix compactabtility check#772
Merged
Merged
Conversation
tarcieri
reviewed
Mar 2, 2023
Member
|
Needs rustfmt, otherwise looks good |
Co-authored-by: Tony Arcieri <bascule@gmail.com>
Contributor
Author
|
Thanks for the quick review. Let me know if it's good now. |
Contributor
Author
|
Working on the test still. |
Contributor
Author
|
Okay, I think it's ready unless you spot anything else. Is it possible for a point-release with this? We have a downstream crate that we'd like to publish with this dependency updated. |
Member
|
You caught me just as I was about to cut a new set of breaking crate releases after merging #770. Backports are a bit messy. |
Contributor
Author
|
Perfect! Thanks for everything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
to_compact_encoded_pointshould return a CtOption where is_some set to 0 if the AffinePoint is non-compactable.The current implementation checks if the EncodedPoint from bytes decodes properly to determine compactability. However, the EncodedPoint will always decode just fine, even when a non-compactable point has been compacted.
Instead, what needs to be checked is if the compacted point and the original affine points Y coordinates match.