Add FieldBytesEncoding trait impls#732
Merged
Merged
Conversation
The `elliptic-curve` v0.13.0-pre.3 release refactored encoding onto a `FieldBytesEncoding` trait which provides curve-specific conversions between `Uint` and `FieldBytes`. This commit adds these trait impls and otherwise cleans up serialization-related code to use the new API. The `*_be_*` and `*_le_*` APIs have all been removed in favor of curves having a canonical endianness each. That's customizable on a per-curve basis via `FieldBytesEncoding`. Also bumps `ecdsa` to v0.16.0-pre.0.
This was referenced Feb 1, 2023
This was referenced Mar 3, 2023
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
elliptic-curvev0.13.0-pre.3 release refactored encoding onto aFieldBytesEncodingtrait which provides curve-specific conversions betweenUintandFieldBytes.This commit adds these trait impls and otherwise cleans up serialization-related code to use the new API.
The
*_be_*and*_le_*APIs have all been removed in favor of curves having a canonical endianness each. That's customizable on a per-curve basis viaFieldBytesEncoding.Also bumps
ecdsato v0.16.0-pre.0.