k256+p256: make FromEncodedPoint return a CtOption
#445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corresponding changes for: RustCrypto/traits#782 Internally these were already returning `CtOption` anyway. It should also simplify the implementation of `GroupEncoding`.
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 64.51% 64.58% +0.07%
==========================================
Files 28 28
Lines 3590 3586 -4
==========================================
Hits 2316 2316
+ Misses 1274 1270 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding changes for:
RustCrypto/traits#782
Internally these were already returning
CtOptionanyway. It should also simplify the implementation ofGroupEncoding.