k256: remove field-montgomery feature
#404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #404 +/- ##
==========================================
+ Coverage 55.52% 62.61% +7.08%
==========================================
Files 29 28 -1
Lines 4214 4026 -188
==========================================
+ Hits 2340 2521 +181
+ Misses 1874 1505 -369 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removes the original legacy field implementation inherited (in modified form) from the `p256` crate. At this point the new field implementations seem fairly solid, so there's little reason to keep it around besides additional complexity.
tarcieri
force-pushed
the
k256/remove-field-montgomery-feature
branch
from
f0156b3 to
069bf3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the original legacy field implementation inherited (in modified form) from the
p256crate.At this point the new field implementations seem fairly solid, so there's little reason to keep it around besides additional complexity.