Leverage const_mut_refs; MSRV 1.83
#667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
const_mut_refs
branch
from
5ca300b to
d72b59a
Compare
tarcieri
force-pushed
the
const_mut_refs
branch
from
d72b59a to
b6c06b0
Compare
tarcieri
added a commit
that referenced
this pull request
Sep 19, 2024
This version leverages the new `core::error::Error` stabilization. We plan on bumping MSRV to 1.83 before a final release to get the `const_mut_refs` stabilization (#667), so this is something of an interim bump.
tarcieri
added a commit
that referenced
this pull request
Sep 19, 2024
This version leverages the new `core::error::Error` stabilization. We plan on bumping MSRV to 1.83 before a final release to get the `const_mut_refs` stabilization (#667), so this is something of an interim bump.
tarcieri
added a commit
that referenced
this pull request
Sep 19, 2024
This version leverages the new `core::error::Error` stabilization. We plan on bumping MSRV to 1.83 before a final release to get the `const_mut_refs` stabilization (#667), so this is something of an interim bump.
tarcieri
force-pushed
the
const_mut_refs
branch
from
90cf782 to
95028da
Compare
tarcieri
force-pushed
the
const_mut_refs
branch
4 times, most recently
from
c0ebcb2 to
64b622e
Compare
tarcieri
force-pushed
the
const_mut_refs
branch
3 times, most recently
from
acf1a26 to
522ea4a
Compare
|
Went ahead and bumped this to 1.8.3.0-beta and removed WIP/draft, though I'll hold off on merging this until 1.83 is stable. This is just the beginning of what's possible: we can rewrite pretty much all of This will also make it possible to have many more common implementations shared among |
tarcieri
force-pushed
the
const_mut_refs
branch
from
522ea4a to
eaf2e62
Compare
Replaces macro-based code sharing between the stack-allocated and heap-allocated `*Uint` types with `const fn` using `const_mut_refs`.
tarcieri
force-pushed
the
const_mut_refs
branch
from
eaf2e62 to
b65b985
Compare
Merged
tarcieri
pushed a commit
that referenced
this pull request
Feb 22, 2025
Fixes a performance regression introduced in #667. Evidently, compiler relies a lot on knowing the slice sizes at compile time, so I'm inlining `schoolbook_multiplication()`, `schoolbook_squaring()`, and `montgomery_reduction_inner()`, so the compiler can optimize in case of `Uint`s. Benchmarks: - `wrapping ops/split_mul, U256xU256` - 26ns to 9ns - `Const Montgomery arithmetic/multiplication, U256*U256` - 41ns to 21ns - `Dynamic Montgomery arithmetic/multiplication, U256*U256` - 62ns to 44ns The effect is less pronounced for longer integers, but sill amounts to 5-10% speedup for U4096. On a higher level, this affects many `crypto-primes` benchmarks, e.g. doubles the speed of Lucas test for U128. Possible addition: I think `panic!` in these functions can be replaced with `debug_assert!`, but I don't insist on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces macro-based code sharing between the stack-allocated and heap-allocated
*Uinttypes withconst fnusingconst_mut_refs.Stabilization of this feature is (hopefully) imminent and the PR to do so is in FCP: rust-lang/rust#129195
I will keep this a draft until the feature has actually been stabilized and made it into a stable Rust release.
Edit: stabilization is currently slated for the 1.83.0 milestone, which is set to be released on November 28th, 2024.