BoxedMontyForm: always use Arc for params
#645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Arc` was previously gated on `std` but is available as `alloc::sync::Arc`. Since `BoxedMontyForm` depends on `alloc` anyway, we can unconditionally use `Arc` for the params. Using `Arc` avoids having to clone/duplicate the params every time a new `BoxedMontyForm` value is made with the same params.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arcwas previously gated onstdbut is available asalloc::sync::Arc.Since
BoxedMontyFormdepends onallocanyway, we can unconditionally useArcfor the params.Using
Arcavoids having to clone/duplicate the params every time a newBoxedMontyFormvalue is made with the same params.