Reverse Concat(Mixed)/Split(Mixed) argument ordering
#526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to a "little endian" `lo, hi` convention for the ordering of
arguments to concatenation methods and the ordering of the returned
2-tuple from split methods.
This is more consistent with the rest of the crate, and the
`Uint { limbs }` which uses a little endian ordering.
Closes #519
tarcieri
added a commit
that referenced
this pull request
Dec 28, 2023
It wasn't updated to reflect the low/high ordering changes from #526
tarcieri
added a commit
that referenced
this pull request
Dec 28, 2023
It wasn't updated to reflect the low/high ordering changes from #526
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to a "little endian"
lo, hiconvention for the ordering of arguments to concatenation methods and the ordering of the returned 2-tuple from split methods.This is more consistent with the rest of the crate, and the
Uint { limbs }array which uses a little endian ordering.Closes #519