Make division methods take NonZero-wrapped divisors
#419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
fjarri
force-pushed
the
div-api
branch
3 times, most recently
from
8d01f99 to
49d70f9
Compare
|
@fjarri if you'd like to get this one merged next, it needs a rebase |
Remove `ct_div_rem_limb_with_reciprocal` and `ct_div_rem_limb`, make `div_rem_limb_with_reciprocal` and `div_rem_limb` `const`.
Remove `const_div_rem()` and `const_div_rem_vartime()`.
|
rebased |
tarcieri
reviewed
Dec 13, 2023
tarcieri
reviewed
Dec 13, 2023
tarcieri
approved these changes
Dec 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the API allowing us to avoid returning
CtChoiceresults, and making some methods redundant. Also that's whatBoxedUintis already doing.ReciprocalAPI by taking aNonZero<Limb>inReciprocal::new()which is nowconst.Reciprocal::ct_new()is removed.Uint::div_rem_limb()andUint::div_rem_limb_with_reciprocal()take aNonZero<Limb>and are nowconst.Uint::ct_div_rem_limb()andUint::ct_div_rem_limb_with_reciprocal()are removed.Uint::div_rem()andUint::div_rem_vartime()are nowconst.Uint::const_div_rem()andUint::const_div_rem_vartime()are removed.Uint::rem()andrem_wide()takeNonZerorhs and make them const.Uint::wrapping_div(_vartime)takeNonZerorhsResidueParams::MODULUSinNonZero.Residue::new_checked()removed sinceResidueParamshas already done that check in compile time.const fnNonZero::as_ref()to get access to the inner value in a const context.