Refactor Integer trait; add Constants/LimbsConstant
#355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit factors all of the associated constants off of the `Integer` trait into separate traits: - The existing `Bounded` trait subsumes `BITS`/`BYTES` - `Constants` provides `ONE` and `MAX` - `LimbsConstant` provides `LIMBS` Methods have been added to `Integer` to query what was previously provided by the constants, allowing `BoxedInteger` to potentially impl the trait. That isn't done yet though, because `BoxedUint` needs more trait impls first to meet the bounds of `Integer`.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit factors all of the associated constants off of the
Integertrait into separate traits:Boundedtrait subsumesBITS/BYTESConstantsprovidesONEandMAXLimbsConstantprovidesLIMBSMethods have been added to
Integerto query what was previously provided by the constants, allowingBoxedIntegerto potentially impl the trait.That isn't done yet though, because
BoxedUintneeds more trait impls first to meet the bounds ofInteger.