Split Zero trait into Zero+ZeroConstant
#335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BoxedUint` type couldn't impl the old `Zero` trait because it requires the value be bound to a constant instead of computed at runtime. This commit splits the original trait into two traits, adding a `fn zero()` to `Zero` which can be used for `BoxedUint`. A blanket impl links the two. This makes it possible to add a `Zero` trait impl for `BoxedUint`, which is included in this commit.
tarcieri
added a commit
that referenced
this pull request
Nov 27, 2023
Now that #335 has been merged allowing `NonZero<BoxedUint>` to be expressed, we can use it as the operand for remainder, eliminating the need to handle division by zero at the type system level. This dramatically simplifies the implementation of `BoxedResidueParams::new` since now all of the remainder calculations are infallible, and is more consistent with the other remainder functions.
tarcieri
added a commit
that referenced
this pull request
Nov 27, 2023
Now that #335 has been merged allowing `NonZero<BoxedUint>` to be expressed, we can use it as the operand for remainder, eliminating the need to handle division by zero at the type system level. This dramatically simplifies the implementation of `BoxedResidueParams::new` since now all of the remainder calculations are infallible, and is more consistent with the other remainder functions.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BoxedUinttype couldn't impl the oldZerotrait because it requires the value be bound to a constant instead of computed at runtime.This commit splits the original trait into two traits, adding a
fn zero()toZerowhich can be used forBoxedUint.A blanket impl links the two.
This makes it possible to add a
Zerotrait impl forBoxedUint, which is included in this commit.