Replace BoxedUint::new with ::zero_with_precision
#327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two APIs are nearly identical. The only difference is the latter is infallible and panics if an invalid precision is given. This also changes `BoxedUint::max` to have the same behavior. Whether they should panic is a debatable point. Indeed having both options would be good, but it should probably return `CtOption` where `BoxedUint::max` was returning `Option`. Regardless, this removes duplication and makes the API at least more consistent with itself.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two APIs are nearly identical. The only difference is the latter is infallible and panics if an invalid precision is given.
This also changes
BoxedUint::maxto have the same behavior.Whether they should panic is a debatable point. Indeed having both options would be good, but it should probably return
CtOptionwhereBoxedUint::maxwas returningOption.Regardless, this removes duplication and makes the API at least more consistent with itself.