Montgomery multiplication support for BoxedUint
#323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an internal `impl_montgomery_reduction!` macro which can be used to abstract over `const fn` use cases as well as `BoxedUint` use cases which would require `const_mut_refs` to be usable from a `const fn`. This is used to define an inner `mul_montgomery_from` function which works on `BoxedUint`. It isn't yet tested/used and marked as `allow(dead_code)`, but I'd like to perform some major refactoring without losing these changes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an internal
impl_montgomery_reduction!macro which can be used to abstract overconst fnuse cases as well asBoxedUintuse cases which would requireconst_mut_refsto be usable from aconst fn.This is used to define an inner
mul_montgomery_fromfunction which works onBoxedUint.It isn't yet tested/used and marked as
allow(dead_code), but I'd like to perform some major refactoring without losing these changes.