Fix aes and kuznyechik CI workflows
#311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
fix-aes-and-kuznyechik-workflows
branch
from
731f35a
to
fac0297
Compare
tarcieri
commented
Mar 17, 2022
| @@ -3,6 +3,7 @@ name: aes | |||
| on: | |||
| pull_request: | |||
| paths: | |||
| - ".github/workflows/aes.yml" | |||
There was a problem hiding this comment.
We should probably do this everywhere in order to ensure changes to a workflow trigger the workflow
Looks like they were broken in #284
tarcieri
force-pushed
the
fix-aes-and-kuznyechik-workflows
branch
from
fac0297
to
35bd0b4
Compare
tarcieri
commented
Mar 17, 2022
| @@ -81,7 +81,7 @@ impl AlgorithmName for Kuznyechik { | |||
| #[cfg_attr(docsrs, doc(cfg(feature = "zeroize")))] | |||
| impl Drop for Kuznyechik { | |||
| fn drop(&mut self) { | |||
| self.keys.zeroize(); | |||
| self.keys.iter_mut().for_each(|key| key.zeroize()); | |||
There was a problem hiding this comment.
Unfortunately the Zeroize impl on core::slice::IterMut couldn't handle this case, I believe because this explicit version works due to implicit deref coercion.
This was referenced Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like they were broken in #284