Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing_debug_implementations #532

Conversation

JonathanWoollett-Light
Copy link
Contributor

@JonathanWoollett-Light JonathanWoollett-Light commented May 26, 2023

Sets missing_debug_implementations to warn and adds missing std::fmt::Debug implementations.

When tracing/logging/debugging a program it is common to debug print inputs and outputs of function, to do this generally dependencies need to offer std::fmt::Debug implementations.

I won't repeat what is written under missing_debug_implementations which gives some more explanation.

Jonathan Woollett-Light added 2 commits May 26, 2023 15:39
Fixes warnings on the lint `clippy::needless_borrow`.

Signed-off-by: Jonathan Woollett-Light <[email protected]>
Fixes warnings on the lint `clippy::explicit_auto_deref`.

Signed-off-by: Jonathan Woollett-Light <[email protected]>
@JonathanWoollett-Light
Copy link
Contributor Author

JonathanWoollett-Light commented May 26, 2023

Blocked on RustCrypto/traits#1315

@JonathanWoollett-Light JonathanWoollett-Light changed the title Missing debug implementations fix: missing_debug_implementations May 26, 2023
@JonathanWoollett-Light
Copy link
Contributor Author

Blocked on RustCrypto/block-modes#46

Signed-off-by: Jonathan Woollett-Light <[email protected]>
@newpavlov
Copy link
Member

This PR got outdated, so I will close it in favor of tracking issue #599.

@newpavlov newpavlov closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants