Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chacha20poly1305: Migrate to universal-hash 0.5 #415

Closed
wants to merge 1 commit into from

Conversation

str4d
Copy link

@str4d str4d commented Apr 21, 2022

@str4d
Copy link
Author

str4d commented Apr 24, 2022

Force-pushed to bump the revision of poly1305.

Benchmarks relative to current master (Ryzen 9 5950X):

chacha20poly1305/encrypt/1024                                                                             
                        time:   [5730.9994 cycles 5734.1911 cycles 5738.3088 cycles]
                        thrpt:  [5.6038 cpb 5.5998 cpb 5.5967 cpb]
                 change:
                        time:   [-1.2771% -1.1631% -1.0515%] (p = 0.00 < 0.05)
                        thrpt:  [+1.0626% +1.1767% +1.2936%]
                        Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
  3 (3.00%) high mild
  11 (11.00%) high severe
chacha20poly1305/decrypt/1024                                                                             
                        time:   [4577.3246 cycles 4579.2528 cycles 4581.4244 cycles]
                        thrpt:  [4.4740 cpb 4.4719 cpb 4.4700 cpb]
                 change:
                        time:   [-4.8783% -4.8231% -4.7705%] (p = 0.00 < 0.05)
                        thrpt:  [+5.0095% +5.0675% +5.1284%]
                        Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
  8 (8.00%) high mild
chacha20poly1305/encrypt/2048                                                                             
                        time:   [7579.3136 cycles 7581.1655 cycles 7583.1663 cycles]
                        thrpt:  [3.7027 cpb 3.7017 cpb 3.7008 cpb]
                 change:
                        time:   [-3.4497% -3.4016% -3.3540%] (p = 0.00 < 0.05)
                        thrpt:  [+3.4704% +3.5214% +3.5729%]
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  4 (4.00%) high mild
  1 (1.00%) high severe
chacha20poly1305/decrypt/2048                                                                             
                        time:   [5446.0425 cycles 5449.1238 cycles 5452.7436 cycles]
                        thrpt:  [2.6625 cpb 2.6607 cpb 2.6592 cpb]
                 change:
                        time:   [-3.5903% -3.5273% -3.4635%] (p = 0.00 < 0.05)
                        thrpt:  [+3.5878% +3.6563% +3.7240%]
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe
chacha20poly1305/encrypt/4096                                                                             
                        time:   [10806.5150 cycles 10808.6504 cycles 10810.7968 cycles]
                        thrpt:  [2.6394 cpb 2.6388 cpb 2.6383 cpb]
                 change:
                        time:   [-5.7002% -5.6510% -5.6044%] (p = 0.00 < 0.05)
                        thrpt:  [+5.9371% +5.9894% +6.0448%]
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
  1 (1.00%) high severe
chacha20poly1305/decrypt/4096                                                                             
                        time:   [6320.5370 cycles 6322.9353 cycles 6325.5618 cycles]
                        thrpt:  [1.5443 cpb 1.5437 cpb 1.5431 cpb]
                 change:
                        time:   [-10.008% -9.8098% -9.6620%] (p = 0.00 < 0.05)
                        thrpt:  [+10.695% +10.877% +11.121%]
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
chacha20poly1305/encrypt/8192                                                                             
                        time:   [17692.2380 cycles 17695.0027 cycles 17697.8457 cycles]
                        thrpt:  [2.1604 cpb 2.1600 cpb 2.1597 cpb]
                 change:
                        time:   [-6.0838% -6.0337% -5.9894%] (p = 0.00 < 0.05)
                        thrpt:  [+6.3710% +6.4212% +6.4779%]
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  1 (1.00%) low severe
  1 (1.00%) high mild
  4 (4.00%) high severe
chacha20poly1305/decrypt/8192                                                                             
                        time:   [8616.7772 cycles 8617.9879 cycles 8619.3565 cycles]
                        thrpt:  [1.0522 cpb 1.0520 cpb 1.0519 cpb]
                 change:
                        time:   [-12.642% -12.517% -12.394%] (p = 0.00 < 0.05)
                        thrpt:  [+14.148% +14.308% +14.472%]
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  1 (1.00%) high mild
  4 (4.00%) high severe
chacha20poly1305/encrypt/16384                                                                             
                        time:   [31527.0595 cycles 31578.1437 cycles 31662.5980 cycles]
                        thrpt:  [1.9325 cpb 1.9274 cpb 1.9243 cpb]
                 change:
                        time:   [-5.2312% -5.1400% -5.0342%] (p = 0.00 < 0.05)
                        thrpt:  [+5.3011% +5.4185% +5.5199%]
                        Performance has improved.
Found 15 outliers among 100 measurements (15.00%)
  4 (4.00%) low mild
  3 (3.00%) high mild
  8 (8.00%) high severe
chacha20poly1305/decrypt/16384                                                                             
                        time:   [13137.3008 cycles 13148.9465 cycles 13164.3202 cycles]
                        thrpt:  [0.8035 cpb 0.8025 cpb 0.8018 cpb]
                 change:
                        time:   [-15.008% -14.964% -14.920%] (p = 0.00 < 0.05)
                        thrpt:  [+17.536% +17.598% +17.659%]
                        Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
  1 (1.00%) low severe
  5 (5.00%) high mild
  7 (7.00%) high severe

They do seem to vary quite a bit between benchmark runs, but the trend is consistent.

@tarcieri
Copy link
Member

Obsoleted by #439

@tarcieri tarcieri closed this Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants