Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Allow plug-in to return a custom value in can_do() #130

Merged
merged 4 commits into from
Nov 7, 2020

Conversation

helgoboss
Copy link
Contributor

Background: Cockos Extensions to VST SDK defines some non-standard behavior controlled via custom can_do() return values (other than 1, 0 or -1). I'm currently using this in ReaLearn.

@helgoboss
Copy link
Contributor Author

Is there anything missing to get this merged? Seems like the Travis build got stuck.

@Boscop
Copy link
Member

Boscop commented Jun 30, 2020

Apparently Travis build failed here (due to formatting): https://travis-ci.org/github/RustAudio/vst-rs/jobs/702150434#L363

@helgoboss
Copy link
Contributor Author

@Boscop Ah, thanks. Will look into it. I was confused by the "Waiting for status to be reported" message.

@Boscop
Copy link
Member

Boscop commented Jul 6, 2020

It failed again:

The command "cargo test --verbose" exited with 0.
0.91s$ cargo fmt --all -- --check
Diff in /home/travis/build/RustAudio/vst-rs/src/api.rs at line 256:
     Yes,
     Maybe,
     No,
-    Custom(isize)
+    Custom(isize),
 }
 
 impl Supported {
Diff in /home/travis/build/RustAudio/vst-rs/src/api.rs at line 282:
             Yes => 1,
             Maybe => 0,
             No => -1,
-            Custom(i) => i
+            Custom(i) => i,
         }
     }
 }
The command "cargo fmt --all -- --check" exited with 1.

Rustfmt requires all enum variants to have commas afterwards.

@helgoboss
Copy link
Contributor Author

Thanks, I haven't yet made any attempt to fix it.

@helgoboss
Copy link
Contributor Author

@Boscop Worked day and night on adding the comma. Now it's finished ;)

@Boscop Boscop requested a review from zyvitski July 8, 2020 16:14
@askeksa askeksa merged commit 1a03c5c into RustAudio:master Nov 7, 2020
askeksa pushed a commit to askeksa/vst-rs that referenced this pull request Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants