This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
Document and add update_display to Host
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askeksa
approved these changes
May 10, 2020
src/host.rs
Outdated
| @@ -147,7 +147,9 @@ pub enum OpCode { | |||
| /// Get the current directory. | |||
| /// [return]: `FSSpec` on OS X, `char*` otherwise | |||
| GetDirectory, | |||
| /// No arguments. TODO: Figure out what this does. | |||
| /// Tell the host that the plugin's parameters have changed, refresh the UI. | |||
| /// | |||
There was a problem hiding this comment.
The travis failure seems to be caused by the trailing space here.
| @@ -222,6 +224,9 @@ pub trait Host { | |||
| fn get_block_size(&self) -> isize { | |||
| 0 | |||
| } | |||
|
|
|||
| /// Refresh UI after the plugin's parameters changed. | |||
There was a problem hiding this comment.
Add to doc comment:
Note: some hosts will call some PluginParameters methods from within the update_display call, including get_parameter, get_parameter_label, get_parameter_name and get_parameter_text.
|
I made the changes to the documentation, but it seems that some problems in the CI may be related to recent changes in Rust's API or style guides. |
|
Clippy issues fixed in d608f3e. Try rebasing your branch onto this commit. That should make it pass the CI. |
* Remove unnecessary parentheses * Remove deprecated `Error::description` (closes #123) * Avoid zero initialization of `AEffect` * Use `to_bits` to get bits from `f32`
|
Done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopens #125
I'm not currently using vst-rs anymore, so I won't be able to properly test this. I'll gladly accept fixes and suggestions before merging.
cc @askeksa