Add server name support #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmedrano
reviewed
Sep 15, 2024
| @@ -128,12 +128,17 @@ fn write_dynamic_loading_src<W: std::io::Write>(out: &mut W) -> Result<(), std:: | |||
| f.type_name() | |||
| )?; | |||
| } else { | |||
| let mut f_name = f.name; | |||
There was a problem hiding this comment.
This probably needs to be locked behind the dynamic loading feature as dynamic linking (write_dynamic_linking_src function) doesn't work due to having the same symbol name ("jack_client_open") and Rust not supporting varargs (rust-lang/rust#44930)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the client to connect to JACK server using a specific server name. Before it could only connect to a single JACK server using the default name. This support is needed if you want to have multiple JACK servers, perhaps to bind to many sound cards at the same time.