Change trim_whitespace implementation to use while let
#913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skgland
force-pushed
the
trim_whitespace
branch
from
7381e31
to
68df9bd
Compare
|
Force Pushed to remove accidental formatting changes in the first of my commits |
For there are already other common string types in str.rs, and trimming white spaces is a common need for string. So this could help further refactoring or re-difining these string functions. Following changes are made here: - move the function from sysctl.rs into str.rs - make the function public - move the tests into an example Signed-off-by: Qidu Teric <[email protected]>
Signed-off-by: Bennet Bleßmann <[email protected]>
originally proposed in a comment at Rust-for-Linux#911 (comment) - using while let allows us to combine all tests and the reminder construction into one pattern - without slice indexing and as such the use of the `Index` trait we can now also make the function `const` - a quick comparison on [Compiler Explorer](https://godbolt.org/z/Ex5dT8ffr) shows no changes in the resulting instructions, at least for the checked constellation Signed-off-by: Bennet Bleßmann <[email protected]>
Skgland
force-pushed
the
trim_whitespace
branch
from
68df9bd
to
42571a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #911 and was originally proposed there in a comment #911 (comment)
The first commit adds two additional tests,
one for the empty string and the second for a string consisting only of spaces (maybe there should also be tests testing for other whitespace beside spaces?).
The second commit does the actual change of introducing
while let.Using
while letallows us to combine the empty and whitespace character checks as well as the remainder calculation into one patter for each loop.As a result of no longer uses slice indexing and as such not using the
Indextrait,the function can now be made
const, which is also done here.Compiler Explorer shows no significant change in assembly output.
playground