Disable stack probes #363
Merged
Disable stack probes #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
We do not support function-call stack probes, and LLVM inline asm stack probe is currently broken [1][2]. Switching target's `stack-probes` to "none" allows us to avoid broken codegen and the intrinsic call. We could switch the `stack-probes` property to `inline` if we want once the LLVM codegen issue is resolved. [1]: https://bugs.llvm.org/show_bug.cgi?id=50165 [2]: rust-lang/rust#84667 Signed-off-by: Gary Guo <[email protected]>
|
Review of
|
|
Is there an issue number tracking the |
ojeda
reviewed
Jun 7, 2021
Comment on lines
-45
to
-47
| define_panicking_intrinsics!("non-inline stack probes should not be used", { | ||
| __rust_probestack, | ||
| }); |
There was a problem hiding this comment.
Do we need to remove this? i.e. can we keep it as a safeguard?
There was a problem hiding this comment.
It's best to remove this so we know there're no calls generated by accident. Note that we will never need __rust_probestack in the future -- once LLVM bug is fixed we'll switch to inline stack probes.
There was a problem hiding this comment.
Removing this ensures that non-inline stack probes are never generated.
Edit: race-condition :)
|
There does not seem to be a tracking issue for inline stack probes on Rust side. |
|
Updated #355 with the LLVM one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not support function-call stack probes, and LLVM inline asm
stack probe is currently broken 1 2. Switching target's
stack-probesto "none" allows us to avoid broken codegen and the intrinsic call.
We could switch the
stack-probesproperty toinlineif we want oncethe LLVM codegen issue is resolved.